[TYPO3-core] Feedback about #46606

[Michael Stucki]

Hi Christian,

Thanks for the fast response! It is almost clear for me now.

Just one thing: I would wish that we stick to the four-eye review process
even though you might think it's a small patch.

I think it makes a big difference, exactly because things might get
overlooked like it happened here...

Greetings, Michael
Am 29.03.2013 14:42 schrieb "Christian Kuhn" <lolli at schwarzbu.ch>:

> Hey.
>
> On 03/29/2013 02:23 PM, Michael Stucki wrote:
>
>> I have some questions about https://review.typo3.org/#/c/**19225/<https://review.typo3.org/#/c/19225/>
>>
>
>
>  - Why is it merged although the subject says it is work in progress?
>>
>
> Yep, that was my fail, I missed the WIP in the title when I reviewed this
> one.
>
>
>  - Why is it reviewed only by one person (Christian)? What happened to
>> the four-eye-review?
>>
>
> The patch is simple. I merged the base patch from #44593, so I know the
> internals and the according follow-up changes are obvious.
> Furthermore, I really hate if core things are deprecated but still used in
> the core. This is always a real hassle later on. Thus, I had some pressure
> to finish these deprecation removal patches after I merged the base flash
> message patch some days ago.
>
>
>  - What are the plans to finish this change, since the originating issue
>> (http://forge.typo3.org/**issues/46606<http://forge.typo3.org/issues/46606>)
>> is closed now?
>>
>
> They are finished now. The two test cases needed a bigger refactoring,
> thats why I didn't include them in the base patch. I've done three further
> patches (2 core, 1 exbase) for this stuff, so the whole topic should be
> finished for now:
>
> https://review.typo3.org/#/c/**19434/<https://review.typo3.org/#/c/19434/>
> https://review.typo3.org/#/c/**19430/<https://review.typo3.org/#/c/19430/>
> https://review.typo3.org/#/c/**19432/<https://review.typo3.org/#/c/19432/>
>
>
>  - Why is there no description of the change?
>>
>
> The title is precise enough, especially together with the "Related:
> #44593" in the commit message.
>
>
> Regards
> Christian
> ______________________________**_________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/**core-mailinglist-rules/<http://typo3.org/teams/core/core-mailinglist-rules/>
> http://typo3.org/development/**bug-fixing/diff-and-patch/<http://typo3.org/development/bug-fixing/diff-and-patch/>
> ______________________________**_________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.typo3.**org <TYPO3-team-core at lists.typo3.org>
> http://lists.typo3.org/cgi-**bin/mailman/listinfo/typo3-**team-core<http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20130329/c1d4ad18/attachment.htm>