<p dir="ltr">Hi Christian, </p>
<p dir="ltr">Thanks for the fast response! It is almost clear for me now. </p>
<p dir="ltr">Just one thing: I would wish that we stick to the four-eye review process even though you might think it's a small patch.</p>
<p dir="ltr">I think it makes a big difference, exactly because things might get overlooked like it happened here... </p>
<p dir="ltr">Greetings, Michael </p>
<div class="gmail_quote">Am 29.03.2013 14:42 schrieb "Christian Kuhn" <<a href="mailto:lolli@schwarzbu.ch">lolli@schwarzbu.ch</a>>:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hey.<br>
<br>
On 03/29/2013 02:23 PM, Michael Stucki wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I have some questions about <a href="https://review.typo3.org/#/c/19225/" target="_blank">https://review.typo3.org/#/c/<u></u>19225/</a><br>
</blockquote>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- Why is it merged although the subject says it is work in progress?<br>
</blockquote>
<br>
Yep, that was my fail, I missed the WIP in the title when I reviewed this one.<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- Why is it reviewed only by one person (Christian)? What happened to<br>
the four-eye-review?<br>
</blockquote>
<br>
The patch is simple. I merged the base patch from #44593, so I know the internals and the according follow-up changes are obvious.<br>
Furthermore, I really hate if core things are deprecated but still used in the core. This is always a real hassle later on. Thus, I had some pressure to finish these deprecation removal patches after I merged the base flash message patch some days ago.<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- What are the plans to finish this change, since the originating issue<br>
(<a href="http://forge.typo3.org/issues/46606" target="_blank">http://forge.typo3.org/<u></u>issues/46606</a>) is closed now?<br>
</blockquote>
<br>
They are finished now. The two test cases needed a bigger refactoring, thats why I didn't include them in the base patch. I've done three further patches (2 core, 1 exbase) for this stuff, so the whole topic should be finished for now:<br>
<br>
<a href="https://review.typo3.org/#/c/19434/" target="_blank">https://review.typo3.org/#/c/<u></u>19434/</a><br>
<a href="https://review.typo3.org/#/c/19430/" target="_blank">https://review.typo3.org/#/c/<u></u>19430/</a><br>
<a href="https://review.typo3.org/#/c/19432/" target="_blank">https://review.typo3.org/#/c/<u></u>19432/</a><br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- Why is there no description of the change?<br>
</blockquote>
<br>
The title is precise enough, especially together with the "Related: #44593" in the commit message.<br>
<br>
<br>
Regards<br>
Christian<br>
______________________________<u></u>_________________<br>
Before posting to this list, please have a look to the posting rules<br>
on the following websites:<br>
<br>
<a href="http://typo3.org/teams/core/core-mailinglist-rules/" target="_blank">http://typo3.org/teams/core/<u></u>core-mailinglist-rules/</a><br>
<a href="http://typo3.org/development/bug-fixing/diff-and-patch/" target="_blank">http://typo3.org/development/<u></u>bug-fixing/diff-and-patch/</a><br>
______________________________<u></u>_________________<br>
TYPO3-team-core mailing list<br>
<a href="mailto:TYPO3-team-core@lists.typo3.org" target="_blank">TYPO3-team-core@lists.typo3.<u></u>org</a><br>
<a href="http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core" target="_blank">http://lists.typo3.org/cgi-<u></u>bin/mailman/listinfo/typo3-<u></u>team-core</a><br>
</blockquote></div>