[TYPO3-core] Feedback about #46606
lolli at schwarzbu.ch
Fri Mar 29 14:42:16 CET 2013
On 03/29/2013 02:23 PM, Michael Stucki wrote:
> I have some questions about https://review.typo3.org/#/c/19225/
> - Why is it merged although the subject says it is work in progress?
Yep, that was my fail, I missed the WIP in the title when I reviewed
> - Why is it reviewed only by one person (Christian)? What happened to
> the four-eye-review?
The patch is simple. I merged the base patch from #44593, so I know the
internals and the according follow-up changes are obvious.
Furthermore, I really hate if core things are deprecated but still used
in the core. This is always a real hassle later on. Thus, I had some
pressure to finish these deprecation removal patches after I merged the
base flash message patch some days ago.
> - What are the plans to finish this change, since the originating issue
> (http://forge.typo3.org/issues/46606) is closed now?
They are finished now. The two test cases needed a bigger refactoring,
thats why I didn't include them in the base patch. I've done three
further patches (2 core, 1 exbase) for this stuff, so the whole topic
should be finished for now:
> - Why is there no description of the change?
The title is precise enough, especially together with the "Related:
#44593" in the commit message.
More information about the TYPO3-team-core