[TYPO3-core] Friendly Ghost

Roland most.wanted at gmx.at
Mon May 28 13:36:33 CEST 2012


thanks for your reply.

> CGL violations FunctionCallArgument in indexed_search
> https://review.typo3.org/11338
> -1 : 8 missed occassions


> CGL violations DoubleQuoteUsageContainsVar
> https://review.typo3.org/11619
> Waiting for one review by testing from anyone (I already reviewed it)

do you mean unit tests? i guess real feature tests will be very hard if not
impossible in the case of such CGL violation fixes. what do you think?

> CGL violations FunctionCallArgumentSpacing in sysext/beuser/
> https://review.typo3.org/11638
> Enough reviews, but cannot be merged due to a conflict.


> CGL violations FunctionCallArgumentSpacing in /typo3/sysext/cms/
> https://review.typo3.org/11639
> Needs some reviews

already 2 positive code rviews. commit is actially a nobrainer and could be
submitted right away by a core developer. (christian handeled it like this
last week a couple of times)

> CGL violations FunctionCallArgumentSpacing in /typo3/sysext/i*/
> https://review.typo3.org/11653
> Needs some reviews

same like abve.

kind regards.


More information about the TYPO3-team-core mailing list