[TYPO3-core] Friendly Ghost

Jigal van Hemert jigal.van.hemert at typo3.org
Mon May 28 15:46:32 CEST 2012


On 28-5-2012 13:36, Roland wrote:
>> CGL violations FunctionCallArgument in indexed_search
>> https://review.typo3.org/11338
>> -1 : 8 missed occassions
> fixed.

>> CGL violations DoubleQuoteUsageContainsVar
>> https://review.typo3.org/11619
>> Waiting for one review by testing from anyone (I already reviewed it)
> do you mean unit tests? i guess real feature tests will be very hard if not
> impossible in the case of such CGL violation fixes. what do you think?

No unit test, just a basic test that the patch can be merged without a 
problem, no PHP errors (you can't always catch every problem by 
reading), etc.

>> CGL violations FunctionCallArgumentSpacing in sysext/beuser/
>> https://review.typo3.org/11638
>> Enough reviews, but cannot be merged due to a conflict.
> fixed.

>> CGL violations FunctionCallArgumentSpacing in /typo3/sysext/cms/
>> https://review.typo3.org/11639
>> Needs some reviews
> already 2 positive code rviews. commit is actially a nobrainer and could be
> submitted right away by a core developer. (christian handeled it like this
> last week a couple of times)

Has no review by a core team members yet.

Jigal van Hemert
TYPO3 Core Team member

TYPO3 .... inspiring people to share!
Get involved: typo3.org

More information about the TYPO3-team-core mailing list