[TYPO3-core] why did jenkins reject my commit?

Christian Kuhn lolli at schwarzbu.ch
Sat May 19 22:08:02 CEST 2012


On 05/18/2012 11:04 AM, Jigal van Hemert wrote:
> Sorry, but if you push something like this to gerrit with syntax errors
> in it, then it means that the code itself was not tried at all!?!?

Wouter and Roland mostly pushed CGL fixes the last days and weeks 
(thanks!). Those patches tend to be hard to test on one side in its full 
expanse, and are no-brainers codewise on the other hand. I usually read 
the patches very carefully (for example Wouter mostly changes only 
method headers) and rely on jenkins to find any fatals that might have 
slipped through. If only comments are changed, it is unlikely that a 
patch breaks the build anyway.
For those cgl patches it is also a nice thing to see only one 
systematically problem fixed per patch. You get some pattern matching 
ability if reading those patches ;)


More information about the TYPO3-team-core mailing list