[TYPO3-core] why did jenkins reject my commit?

Steffen Gebert steffen.gebert at typo3.org
Fri May 18 23:48:10 CEST 2012


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Roland,

the workshops during the DevDays were no talks, so it would have been
hard to record them.

Basically you should test everything you could imagine to be broken
afterwards (and a bit more).

But don't worry too much: We have - besides Jenkins - a review workflow
for that. So there are other people around (at least one team member),
who will have to have a look at your changes.

Kind regards
Steffen

- -- 
Steffen Gebert
TYPO3 v4 Core Team Member
TYPO3 Server Administration Team Member

TYPO3 .... inspiring people to share!
Get involved: http://typo3.org

I work for TYPO3 solely in my spare time. If you think that
my work helps you running your business, you are invited to
send me a donation via PayPal to this email address. Thanks

On 18.05.12 23:39, Roland wrote:
>> So how would new contributers find out what is wrong with their patch the
>> commit to Gerrit? IMHO this needs to be documented somewhere.
>> To keep the motivation of the new contributers the same as before
>> pushing it to Gerrit:-)
> 
> i would like to have a some more detailed guide what and how to test before
> i push a commit. is there something in the wiki? the contribution
> walkthrougguide does not tell anything about it. nobody wants to break
> something. maybe some of the TDD12 sessions would have been helpful. i
> could not attend. unfortunatelly they were not recorded. maybe this would
> have been helpful?
> 
> ps: how safe is the jenkins safety net?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPtsOaAAoJEIskG/rSlyw4k88IAKMQ+Za9ByxtbvOMjLNDczCS
DF7XsQfNQ21aTbv2gZ6h3RsB0msdAzR07YM6JSVHBmeG+r5Tb8TLVWhRlBE+aPDR
O3YCecDtqoWUMa636UeyoiwQ0sKPcjlhUkWjjygCsI0awIkCn+csoxU/ujMxbx84
grp2Q8wvPskUS3kcFgoYG3d0fchIFcrByfdmkWKeJ2tXJCKP/TT2JjnH811ySUX4
vdI4EedJSP3hu54lDubJqN1nngI3q0eCxdABzmdSyCF0A/XkB0GN11iBlz0Pn9RF
MadC6Imad1gqoHVhZO2meDviXynPCPMWkN102nAx/08Lz2CTwMyaKUDOOMrx1jI=
=oZMo
-----END PGP SIGNATURE-----


More information about the TYPO3-team-core mailing list