[TYPO3-core] RFC #15689: Feature: Allow easy use of lightbox style image enlargement in the frontend

[Helmut Hummel]

Hi,

On 12.09.10 17:40, Dmitry Dulepov wrote:
> 
> Susanne Moog wrote:
>> +	$typoLinkConf = array_merge(array('parameter' => $url), $conf['linkParams.']);
> 
> There is no real need for array_merge here and extra array... This will do:
> 
> $conf['linkParams.']['parameter'] = $url;
> 
> Simpler, faster and takes less memory.

Agreed.

I also don't understand the use of array_merge here:

> +$url = $this->IMG_RESOURCE(
> +	array_merge(array('file' => $imageFile, 'file.' => $conf))
> +	);

> Also some blocks could go to dedicated functions. This would enhance
> readability of the code.

This should be done in another RFC.

> Thanks for the patch, Susanne!

Yepp!

Regards Helmut