[TYPO3-core] RFC #15689: Feature: Allow easy use of lightbox style image enlargement in the frontend
Steffen Kamper
info at sk-typo3.de
Mon Sep 13 00:15:04 CEST 2010
Hi,
Dmitry Dulepov schrieb:
> Hi!
>
> It would be great if lightbox can be finally integrated to TYPO3 :) Btw,
> ExtJS (Ext Core to be precize) has a nice lightweight lightbox, which we
> could supply by default for everybody with TYPO3.
>
this would require to include ExtCore or ExtJs in FE.
I already modified the Ext Lightbox for frontendeditadvanced to be able
to use iframe as well - we could add this to core library to have a
default lightbox possible.
> I did not test the patch, just quickly scrolled through it. I did not find
> anything bad. However one small thing that can be optimized.
>
> Susanne Moog wrote:
>> + $typoLinkConf = array_merge(array('parameter' => $url), $conf['linkParams.']);
>
> There is no real need for array_merge here and extra array... This will do:
>
> $conf['linkParams.']['parameter'] = $url;
>
> Simpler, faster and takes less memory.
>
I agree. Same for the other one:
> Also some blocks could go to dedicated functions. This would enhance
> readability of the code.
>
i don't see this with the changed code.
Other than that +1 by reading and testin. A live example can be found here:
http://www.steffenkamper.info/last/index.php?id=26
vg Steffen
More information about the TYPO3-team-core
mailing list