[TYPO3-core] RFC #15689: Feature: Allow easy use of lightbox style image enlargement in the frontend

[Dmitry Dulepov]

Hi!

It would be great if lightbox can be finally integrated to TYPO3 :) Btw,
ExtJS (Ext Core to be precize) has a nice lightweight lightbox, which we
could supply by default for everybody with TYPO3.

I did not test the patch, just quickly scrolled through it. I did not find
anything bad. However one small thing that can be optimized.

Susanne Moog wrote:
> +	$typoLinkConf = array_merge(array('parameter' => $url), $conf['linkParams.']);

There is no real need for array_merge here and extra array... This will do:

$conf['linkParams.']['parameter'] = $url;

Simpler, faster and takes less memory.

Also some blocks could go to dedicated functions. This would enhance
readability of the code.

Thanks for the patch, Susanne!

-- 
Dmitry Dulepov
TYPO3 core&security team member
Twitter: http://twitter.com/dmitryd
Read more @ http://dmitry-dulepov.com/