[TYPO3-core] RFC#15562: Bug/Nobrainer: PHP warning str_pad() in t3lib_div

[François Suter]

Hi,

> I never intended to touch any other things than these quotes.
> But I had a response
> (http://lists.typo3.org/pipermail/typo3-team-core/2010-August/042554.html)
> that requested me to fix some CGL issues.
> I don't think it makes sense to fix CGL only for 2 lines, so I adjusted the
> whole "paragraph".
> But if Core Team says to keep the other lines, it's ok for me of course. np

IMO it's ok to fix other lines, but the risk is that your changes become 
hard to make out in the midst of purely CGL-related fixes. One thing you 
can do in such cases is to submit 2 versions of your patch, one normal 
and one without white-space differences (svn diff -x -w).

Cheers

-- 

Francois Suter
Cobweb Development Sarl - http://www.cobweb.ch