[TYPO3-core] RFC#15562: Bug/Nobrainer: PHP warning str_pad() in t3lib_div

Oliver Klee typo3-german-02 at oliverklee.de
Thu Aug 26 12:29:38 CEST 2010


Hi,

+1 by reading if you fix the following CGL nits:

- drop the spaces after the opening parenthesis
- add a space after each comma

Am 26.08.2010 12:17, schrieb Markus Klein:
> Branches:
> Trunk, 4-4

I think 4.2 and 4.3 are affected as well.

By the way, your diff had the Content-Type: application/octet-stream;.
This caused my Thunderbird to not display the attachment inline, making
the review more work. Could you please change this to text/x-patch; or
text/plain;? Thanks! :-)


Oli
-- 
Certified TYPO3 Integrator | TYPO3 Security Team Member


More information about the TYPO3-team-core mailing list