[TYPO3-core] RFC #13750: Bug: Several GIFBUILDER features broken for IM4, IM6 and GM
Oliver Klee
typo3-german-02 at oliverklee.de
Sat May 29 11:44:45 CEST 2010
Hi Jigal,
Am 29.05.2010 11:12, schrieb Jigal van Hemert:
> Attached version 2 of the testcase. Modifications:
Kudos for providing those tests! They really look good (and I'm very
happy to see more people providing tests for the core).
Two suggestions for the tests:
1. If you use explicit "telling" array keys (and drop the // comment) in
the data provider, you get the benefit of those keys getting displayed
in phpunit, and the data provider is more easier to read. Example:
'unescaped single quotes'.
2. I recommend using @param for the test (even if the parameter names
already are very good), just to make everything explicit.
All the best,
Oli
--
Certified TYPO3 Integrator | TYPO3 Security Team Member
More information about the TYPO3-team-core
mailing list