[TYPO3-core] RFC #13750: Bug: Several GIFBUILDER features broken for IM4, IM6 and GM
Jigal van Hemert
jigal at xs4all.nl
Sat May 29 13:50:51 CEST 2010
Hi Oli,
Oliver Klee wrote:
> Am 29.05.2010 11:12, schrieb Jigal van Hemert:
>> Attached version 2 of the testcase. Modifications:
>
> Kudos for providing those tests! They really look good (and I'm very
> happy to see more people providing tests for the core).
>
> Two suggestions for the tests:
Steffen Gebert introduced the tests here, I merely modified them
according to what should be expected from this function.
> 1. If you use explicit "telling" array keys (and drop the // comment) in
(...)
> 2. I recommend using @param for the test (even if the parameter names
(...)
Are these blocking issues? (Just to be sure how much this is needed ;-) )
--
Jigal van Hemert
skype:jigal.van.hemert
msn: jigal at xs4all.nl
http://twitter.com/jigalvh
More information about the TYPO3-team-core
mailing list