[TYPO3-core] RFC #14028: Code cleanup: Cleanup: class.t3lib_userauthgroup.php

[Kjeld Schumacher]

Hi,
I did not work with Unit Test a lot, but I can try to wrote some for 
this patch.
I will try to spend some time on next weekend on this issue...

Bye,
Kjeld

On 05/22/2010 09:38 PM, Benjamin Mack wrote:
> Hey Kjeld,
>
> gotta tell you:
> I updated the patch and added public/protected elements to the 
> functions, and also did some more cleanup. Have a look at the attached 
> patch.
>
> I see that you introduced $returnValues for most of the functions 
> instead of early returns. However, these have *huge* side effects! 
> Check out the function "checkAuthMethod" and think about the function 
> call if you're an admin! Please make sure that it works as before, 
> maybe through unit tests, would you care to add some?
>
> All the best,
> Benni.
>
> On 07.05.10 18:25, Kjeld Schumacher wrote:
>> Hi,
>> attached version 3. Please test this patch again, because I replaced a
>> lot return statements and might did some failures even if I looked three
>> times over the patch... ;-)
>> Also the reset() and $key variable in a foreach mentionend by Georg
>> Ringer are cleaned.
>>
>> have a nice weekend.
>>
>> Bye
>> Kjeld
>>
>
>
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core


-- 
Kjeld Schumacher
__________________________________________________
Programmierer
not-only-pixel.de

tel: (030) 60 40 91 59
mobil: (0179) 79 53 101
mail: ks at not-only-pixel.de
web: http://not-only-pixel.de