[TYPO3-core] RFC #14028: Code cleanup: Cleanup: class.t3lib_userauthgroup.php

[Benjamin Mack]

Hey Kjeld,

gotta tell you:
I updated the patch and added public/protected elements to the 
functions, and also did some more cleanup. Have a look at the attached 
patch.

I see that you introduced $returnValues for most of the functions 
instead of early returns. However, these have *huge* side effects! Check 
out the function "checkAuthMethod" and think about the function call if 
you're an admin! Please make sure that it works as before, maybe through 
unit tests, would you care to add some?

All the best,
Benni.

On 07.05.10 18:25, Kjeld Schumacher wrote:
> Hi,
> attached version 3. Please test this patch again, because I replaced a
> lot return statements and might did some failures even if I looked three
> times over the patch... ;-)
> Also the reset() and $key variable in a foreach mentionend by Georg
> Ringer are cleaned.
>
> have a nice weekend.
>
> Bye
> Kjeld
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 14028_v5.patch
Type: text/x-patch
Size: 80869 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100522/9003bb8b/attachment-0001.bin>