[TYPO3-core] RFC #14247: Add a compressor/concatenator for CSS and JS

[Susanne Moog]

On 01.05.2010 11:52, Susanne Moog wrote:
> Hi Helmut, hi all,
> 
> On 01.05.2010 01:53, Helmut Hummel wrote:
>>> have to clarify a bit: committed v4 _without_ the unused compression
>>> functions.
>>
>> Thanks for that.
>>
>> I did a bit of testing and found some issues like:
>> * file_exists calls do not work because they use a relative path
>> * cssFixRelativeUrlPaths() has the $newDir parameter which is not used
>> * compression is not used ;)
>> * compression function had some minor flaws
>>
>> Find attached a patch that fixes these things.
> 
> thanks for the new version. I took your version and reworked it a bit.
> - uses pageRenderer->doCompress
> - either compress the files or concatenate them or both (all cases work
> independently)
> - only concatenate files with media="all" set (so skins can bring a
> print stylesheet)
> - adjusted the regex as it replaced relative image paths recursively (so
> you got ../some/directory/../../some/directory/../../some ...)

sorry, missed one file_get_contents call with wrong path (thanks to
Steffen Ritter for noticing)

Attached v2.

> Please test and review :)

Susanne
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 14247_compressionEnabled_v2.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100501/27c3c030/attachment.txt>