[TYPO3-core] RFC #13662: [saltedpasswords] Enhance Unit Tests by testing passwords of various character classes

[Martin Kutschker]

Marcus Krause schrieb:
> Am 24.03.2010 21:20, schrieb Martin Kutschker:
>> Marcus Krause schrieb:
>>> Am 24.03.2010 18:02, schrieb Martin Kutschker:
>>>> Marcus Krause schrieb:
>>>>> Note:
>>>>> When working with the diff file, please make sure to have ISO8859-1
>>>>> defined for your TYPO3 core project.
>>>> For the hardcoded test strings? I was wondering if they are a good idea.
>>> Could you please explain this a bit more? Yes, test string characters
>>> are from ISO-8859-1.
>> I recall a discussion of the right character set for PHP files, but cannot remember if it is
>> iso-8859-1 or utf-8. And as also the text editor must be set correctly I'm a bit wary when it comes
>> to "accented" characters in PHP code.
> 
> Okay, understood. I'm sure for Core stuff mandatory charset is
> ISO-8859-1. So you were worrying about the charset to use - not about
> this RFC in general.

Right. This is for me now ok. But as I'm not into the unit tests of TYPO3 so I cannot give you a +1,
but the code looks straightforward enough to get a +1 from somebody else easily.

Masi