[TYPO3-core] RFC #13662: [saltedpasswords] Enhance Unit Tests by testing passwords of various character classes

[Marcus Krause]

Am 24.03.2010 21:20, schrieb Martin Kutschker:
> Marcus Krause schrieb:
>> Am 24.03.2010 18:02, schrieb Martin Kutschker:
>>> Marcus Krause schrieb:
>>>> Note:
>>>> When working with the diff file, please make sure to have ISO8859-1
>>>> defined for your TYPO3 core project.
>>> For the hardcoded test strings? I was wondering if they are a good idea.
>>
>> Could you please explain this a bit more? Yes, test string characters
>> are from ISO-8859-1.
> 
> I recall a discussion of the right character set for PHP files, but cannot remember if it is
> iso-8859-1 or utf-8. And as also the text editor must be set correctly I'm a bit wary when it comes
> to "accented" characters in PHP code.

Okay, understood. I'm sure for Core stuff mandatory charset is
ISO-8859-1. So you were worrying about the charset to use - not about
this RFC in general.


>>> BTW, you seem to use windows-1252 not iso-8859-1.
>>
>> How do you determine this? My local diff is ISO-8859-1. I assume the one
>> from bugtracker has also ISO-8859-1.
> 
> That's easy. Look at this line from your patch:
> 
> $password = '^.!?"§$%#&@<>«»(){}[]=\\`Ž~,;_-+*/:\'¡¥¹';
> 
> At least Ž is not part of iso-8859-1. See

Okay, I see. I will create and send a new patch packed in an archive (to
be absolutely sure). ;-)


Marcus.