[TYPO3-core] RFC #13283: Thumbnail generation broken for PDF files

[Michael Stucki]

Hi Steffen,

> I don't see a reason to set default to -1 as only is checked if frame is
> gt 0.

That is true, but still you kept it in your updated patch. I've made a
new one which keeps the default value at 0.

> Why is parameter ommited if frame is 0? Installtool always check
> "...pdf_from_imagemagick.pdf"[0] and it works.

Right.

> And one more, isn't it possible to show a frame of an anigif with frame
> option?

There are many files which can have frames, so v7 was wrong in any case.
At least TIFF can be multipage and allows IM/GM to specify a frame.

But even more important is that _every_ file can be opened with a frame
specified. As long as the frame is 0, IM/GM will not refuse to open it
(as if it would be left out).

This means that the check for the filetype is not needed at all. You can
just append the frame in every case (except if "noFramePrepend" is set
in the Install Tool).

> So sry for my comments, but patch doesn't satisfy me by reading.
> I'm sorry that i can't test this as i have problems getting gs into
> action on my windows system.

OK, I have a new patch for you which hopefully satisfies you much
more... :-)

Find attached v9 with the following changes:
- Append the frame parameter for every file, not just PDFs
- Move whitespace after the frame value to the commandline

Cheers, Michael

PS: Disclaimer! The solution of this patch was sponsored at the bug
auction at T3BOARD10. We promised to get it fixed asap, and according to
our tests, it is working perfectly now.

PPS: I would like to thank Andy Grunwald who is sitting next to me and
helped me to catch this gremlin. It looked like a no-brainer to us, but
now we've been working on it for already 3 hours...
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: bug_13283_v9.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100306/991c2724/attachment.txt>