[TYPO3-core] RFC #14356: feature: Make disable_controls available for all group fields, not just type "file"

S. Teuber teuber at stibes.de
Sat Jun 12 15:56:52 CEST 2010


Bump, since this seems to need another +1. It's not in the current dev  
snapshot
of 4.4 yet although Benni thinks it can be included.

Anyone care for a quick review?

Cheers,

Sven


Am 14.05.2010, 22:51 Uhr, schrieb Steffen Gebert  
<steffen at steffen-gebert.de>:

> Hi Sven,
>
> thanks for your (I assume first) patch!
> Nice to get always new people in!
>
>> Type: feature
>>
>> Branches:
>> trunk & TYPO3_4-3
>
> New features can't get into already released versions, thus 4.3 is
> impossible.
> Unfortunately we're currently in a phase called "feature freeze", which
> also disallows adding new features to "trunk", but only fixing bugs.
> This phase will end by the release of 4.4 (or maybe a bit fewer when 4.4
> gets branched in SVN).
>
> Only chance is that Mr. Release Manager (Benni Mack) considers this as a
> bug or allows it as a tiny exception.
>
>> Problem:
>> The useful option "disable_controls" for TCE "group" fields currently
>> only works for the subtype "file", not for the other subtypes ("folder"
>> and "db").
>
> How to test: Add 'disable_controls' => 'browser' to an entry of type
> 'group' (e.g. storage_pid). The browser link (folder icon) of the field
> "General Records Storage Page" in the page properties will disappear.
>
> As this patch does it's job, you get my +1 by testing. I've attached a
> version, which obeys the Coding Guide Lines [1] and is built against
> typo3_src directory - which adds the +1 by reading of my review.
>
> I've written a (german) article [2] some time ago, which explains how to
> provide core patches (besides the official (outdated/wrong) page  
> somewhere
> on typo3.org).
>
> Please don't be disappointed with all this nitchpicking, but it's all to
> ensure the high code quality, which we expect from TYPO3!
> So go on sending patches! The first one is always the hardest one :)
>
> If Benni doesn't decide to include this in 4.4, please bring this up  
> after
> the release of 4.4!
>
> Thanks for your contribution
> Steffen
>
> --
>
> [1]
> http://typo3.org/documentation/document-library/core-documentation/doc_core_cgl/current/
> [2] http://typo3blogger.de/ab-in-den-core/


More information about the TYPO3-team-core mailing list