[TYPO3-core] RFC #12679: Pagemodule don't show clipboard paste icon when there is no content

[Reinhard Führicht]

Am 2010-07-12 15:52, schrieb Oliver Klee:
> Hi,
>
> some remarks on a cursory scan:
>
> - Please use "protected" instead of "var".
> - Please don't set $dblist->pObj from the outside, but please use a
> setter instead.
> - You don't need the explicit reference here: $dblist->pObj =&$this;
> - Please add the missing @var documentation comment to the new member.
> - You add code to an already long function (AFAICS). Why not put the new
> code in a new well-named function?
>
>
> Oli

Fixed in attached v5.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 12679_v5.diff
Type: text/x-patch
Size: 8246 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100712/24aeaabf/attachment-0001.bin>