[TYPO3-core] RFC #12679: Pagemodule don't show clipboard paste icon when there is no content

Oliver Klee typo3-german-02 at oliverklee.de
Mon Jul 12 15:52:22 CEST 2010


Hi,

some remarks on a cursory scan:

- Please use "protected" instead of "var".
- Please don't set $dblist->pObj from the outside, but please use a
setter instead.
- You don't need the explicit reference here: $dblist->pObj = &$this;
- Please add the missing @var documentation comment to the new member.
- You add code to an already long function (AFAICS). Why not put the new
code in a new well-named function?


Oli
-- 
Certified TYPO3 Integrator | TYPO3 Security Team Member


More information about the TYPO3-team-core mailing list