[TYPO3-core] RFC: #16134: TYPO3 doesn't always fix permissions for new files

Tolleiv.Nietsch info at tolleiv.de
Sat Dec 4 09:51:25 CET 2010


Am 01.12.2010 10:48, schrieb Christian Kuhn:
> - Add at least unit test for the t3lib_div changes

None of the patched t3lib_div methods has a basic coverage within the 
existing unit tests, it might take some time to write up proper tests 
for things like t3lib_div::sysLog or t3lib_div::deprecationLog and imho 
it doesn't make sense at all to test things like 
t3lib_div::png_to_gif_by_imagemagick which just call imagemagik with a 
certain parameter set.

> - enable_install_tool is not permission fixed, too

It is - typo3/sysext/setup/mod/index.php lines 348/349


Btw. find a second version of the patch attached which fixes another 
occurrence within t3lib_div.

Cheers,
Tolleiv
-- 
Tolleiv Nietsch
www.tolleiv.de - www.aoemedia.de
Twitter: http://www.twitter.com/tolleiv
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 16134v2.patch
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101204/d0102f0f/attachment.txt>


More information about the TYPO3-team-core mailing list