[TYPO3-core] RFC #6872: Add suggest-like feature to TCEforms

Andreas Wolf typo3ml at andreaswolf.info
Thu Sep 3 22:50:33 CEST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Rupert Germann schrieb:
>> 2) IE7 only: When I select an item from the suggestion list, the
>> title of this item is always "undefined" in the 'selected' box.
>> After saving the record, everything looks fine.
> 
> confirmed

I'll test it tomorrow, when I have access to Win/IE again.

>> 3) All browsers: If result items have long titles, the title in the
>> dropdown list breaks into two or more lines, smashing the layout (see
>> appended screenshot).
>
> confirmed

This is fixed in attached v9. Just took a little CSS tweak.

>> Since cropping is used here with BE_USER->uc['titleLen'], the width
>> of the dropdown list should be raised accordingly to avoid
>> linebreaks. Individual setting of the title lenght would be even
>> more comfortable (like TCEFORM.default.suggest.maxPathTitleLength).
>> Reducing the title lenght on a user basis to <19 is not an option
>> here ;-) Another solution would be to fix the layout to support
>> multiline item titles.
>
> I think the latter one would be best.
>
>> 4) Wishlist: Take ['ctrl']['label_alt'] and ['label_alt_force'] into
>> account in the SELECT part of
>> t3lib_TCEforms_Suggest_DefaultReceiver->prepareSelectStatement()
>
> I'd say this is a very important missing feature.
> as a be user I woud expect suggest to search in the visible titles.
>
> that means if I have set
> label, label_alt, label_alt2 and label_alt_force
> suggest should search in all 3 fields.

I also added this in v9. There is only one problem: If you e.g. search
in tt_content fields, it also searches inside bodytext. But if you don't
search for whole phrases, it will only match the beginning. So we should
definitely make this configurable on a per-table basis.

Btw., label_alt2 does not exist in the core. I saw it in tt_news, but it
is mapped back to label_alt there.

>> Once again thank you very much, the suggest feature is a very cool
>> thing.
>
> I want it in 4.3, too.
> but in the current state the patch still needs a lot of work
> my zend gives my quite a lot of warning concerning not used or not
> existing vars.

Are you sure these are coming from my patch? I was rather sure that I
declared all variables I'm using. But it is quite possible that there
are some glitches, as this patch has gone through more than 1 1/2 years
of development and at least nine versions upto today.

Regards
Andreas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqgLBkACgkQHWtXp155bP/uGgCeJy2AAKym3Lch39BshKVofoZ8
8+sAnA4I8WVM5dI3znSPST3QLNrArdEe
=/CN+
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0006872_tceforms-suggest-v8-to-v9.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090903/25ca6e59/attachment-0002.txt 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0006872_tceforms-suggest-v9.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090903/25ca6e59/attachment-0003.txt 


More information about the TYPO3-team-core mailing list