[TYPO3-core] RFC: #10650: shortcut icon type detection does not work if allow_url_fopen is disabled

Stefan Geith typo3dev2009.nospam1 at geithware.de
Mon Oct 26 10:52:07 CET 2009


REMINDER.

Stefan Geith schrieb:
> Susanne Moog schrieb:
>> Stefan Geith schrieb:
>>> It would also be a better default using $iconMimeType =
>>> 'type="image/x-icon"' than the empty string
>>> if the finfo_open function doesn't exist.
>>
>> aren't you using the wrong "else" part if you want to set this if the
>> finfo_open function doesn't exist? (and the wrong variable?)
>> [...]
>> Additionally the "$iconMimeType = ' type="image/x-icon"';" should be
>> given to the pagerenderer 
>> ($pageRenderer->setIconMimeType($iconMimeType);).
> 
> Yes, you're right ...
> New Patch (v4) attached.
> 
> /Stefan
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
> 
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core



More information about the TYPO3-team-core mailing list