[TYPO3-core] RFC: #10650: shortcut icon type detection does not work if allow_url_fopen is disabled

[Susanne Moog]

Hi,

Stefan Geith schrieb:
> Susanne Moog schrieb:
>> Stefan Geith schrieb:
>>> It would also be a better default using $iconMimeType =
>>> 'type="image/x-icon"' than the empty string
>>> if the finfo_open function doesn't exist.
>>
>> aren't you using the wrong "else" part if you want to set this if the
>> finfo_open function doesn't exist? (and the wrong variable?)
>> [...]
>> Additionally the "$iconMimeType = ' type="image/x-icon"';" should be
>> given to the pagerenderer 
>> ($pageRenderer->setIconMimeType($iconMimeType);).
> 
> Yes, you're right ...
> New Patch (v4) attached.

+1 by reading v4.

Best regards,

Susanne

-- 
Susanne Moog
- Webentwicklung -

NEUSTA GmbH

Contrescarpe 1
28203 Bremen
Fon: +49(0)421.20696-0
Fax: +49(0)421.20696-99
s.moog at neusta.de
www.neusta.de

Geschäftsführende Gesellschafter: Carsten Meyer-Heder, Dirk Schwampe
Registergericht: Amtsgericht Bremen
Handelsregister: HRB 14039