[TYPO3-core] RFC: #10650: shortcut icon type detection does not work if allow_url_fopen is disabled

Stefan Geith typo3dev2008.nospam1 at geithware.de
Mon Oct 19 09:53:00 CEST 2009


Susanne Moog schrieb:
> Stefan Geith schrieb:
>> It would also be a better default using $iconMimeType =
>> 'type="image/x-icon"' than the empty string
>> if the finfo_open function doesn't exist.
> 
> aren't you using the wrong "else" part if you want to set this if the
> finfo_open function doesn't exist? (and the wrong variable?)
> [...]
> Additionally the "$iconMimeType = ' type="image/x-icon"';" should be
> given to the pagerenderer ($pageRenderer->setIconMimeType($iconMimeType);).

Yes, you're right ...
New Patch (v4) attached.

/Stefan
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 010650-favicon-v4.patch
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20091019/c1711fb7/attachment.txt>


More information about the TYPO3-team-core mailing list