[TYPO3-core] FYI: Fixed bug #12300: Output compression breaks prompt for keyboard input in CLI scripts

[Martin Kutschker]

Dmitry Dulepov schrieb:
> Hi!
> 
> Rupert Germann wrote:
>> FYI: the attached patches were committed to
>> 4_2 branch rev 6219
>> 4_1 branch rev 6220
> 
> The patch is a hack. I would like to revert it. We should not put hacks into the core.
> 
> This patch does not prevent ob_start() and compression but undoes it. What's the point to start it and then undo? Isn't it better simply skip ob_start() when running in the CLI mode?
> 
> In addition the patch has this:
> 
> +header('Content-Encoding: None', TRUE);
> 
> Headers are not shown in CLI output, so this code is not needed.

Setting the headers in CLI mode is ignored. I've verified that.

> I would prefer a different solution: do not start compression if it is a CLI mode. It is a much cleaner way. See the attached patch.

If this is the whole point of the affair: yes!

Though I think those two methods in t3lib_div won't hurt if they stay. *If the additional behaviour
of setting the content encoding gets documented.

Masi