[TYPO3-core] RFC #12272: Steps disregarded in t3lib_lock

[Oliver Hader]

Hi Christian,

Christian Kuhn schrieb:
> Hey again,
> 
> Christian Kuhn wrote:
>> Dan Osipov wrote:
>>> This is an SVN patch request.
>>>
>>> Type: Bugfix
>>>
>>> Bugtracker references:
>>> http://bugs.typo3.org/view.php?id=12272
>>>
>>> Branch: 4.2, Trunk
>>>
>>> Problem:
>>> If steps are passed as a parameter, its disregarded, and default 200 is
>>> used instead.
>>>
>>> Solution: Rename the variable to match what is passed.
>> +1 by reading. This is a classic typo.
> 
> $this->step and $steps are awful variable names anyway. This is a
> protected variable (and actually not reset throughout the core), so we
> could easily rename the whole thing to something like
> $sleeptimeInMilliseconds. What do you think?

Unfortunately we cannot since the variable is protected and not private
and we have a XCLASS definition in that t3lib_lock. Thus, an extension
could override the original behaviour but rely on $this->step - even if
the name is not nice.

Thus, I suggest to keep $this->step...

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3