[TYPO3-core] RFC #12272: Steps disregarded in t3lib_lock

Martin Kutschker masi-no at spam-typo3.org
Wed Oct 21 11:20:11 CEST 2009


Oliver Hader schrieb:
>> $this->step and $steps are awful variable names anyway. This is a
>> protected variable (and actually not reset throughout the core), so we
>> could easily rename the whole thing to something like
>> $sleeptimeInMilliseconds. What do you think?
> 
> Unfortunately we cannot since the variable is protected and not private
> and we have a XCLASS definition in that t3lib_lock. Thus, an extension
> could override the original behaviour but rely on $this->step - even if
> the name is not nice.

The idea was that all protected methods and properties are subject to change. An XCLASS is only a
helper to ease hacking not a contract. If we cannot change protected methods and properties for the
sake of XCLASSes we can drop the "protected" declaration right away.

Masi


More information about the TYPO3-team-core mailing list