[TYPO3-core] RFC #12272: Steps disregarded in t3lib_lock

Christian Kuhn lolli at schwarzbu.ch
Wed Oct 21 03:40:45 CEST 2009


Hey again,

Christian Kuhn wrote:
> Dan Osipov wrote:
>> This is an SVN patch request.
>>
>> Type: Bugfix
>>
>> Bugtracker references:
>> http://bugs.typo3.org/view.php?id=12272
>>
>> Branch: 4.2, Trunk
>>
>> Problem:
>> If steps are passed as a parameter, its disregarded, and default 200 is
>> used instead.
>>
>> Solution: Rename the variable to match what is passed.
> 
> +1 by reading. This is a classic typo.

$this->step and $steps are awful variable names anyway. This is a
protected variable (and actually not reset throughout the core), so we
could easily rename the whole thing to something like
$sleeptimeInMilliseconds. What do you think?

Cheers
Christian


More information about the TYPO3-team-core mailing list