[TYPO3-core] RFC #11154: calls to deprecated function makeInstanceClassName in core
Steffen Kamper
info at sk-typo3.de
Fri May 22 14:13:20 CEST 2009
Hi Franz,
Franz Koch schrieb:
> Hi Steffen,
>
> Hmm, I just searched the core for this. There is the following TS option
> (also described in TSref):
> "config.incT3Lib_htmlmail", type boolean, desc: "Include
> t3lib/class.t3lib_htmlmail.php"
>
> This option is checked in class.tslib_pagegen.php inside the method
> "getIncFiles", that is handling the includeLibs (lines 283 to 285).
>
> It's the only place where this is checked, and I found no other piece of
> code that is checking for the availability of class t3lib_htmlmail then
> 'fe_adminLib.inc'. So, although the comment in fe_adminLib.inc says that
> "autoloading should be avoided", I now also think that the check for the
> class can be dropped here, as it really doesn't make sense at this
> point. I attached a new patch where this is fixed now - but I included a
> check if the returned instance from t3lib_div::makeInstance is a valid
> object.
>
this makes now sense to me.
> In addition to that, I think the TS-option "config.incT3Lib_htmlmail"
> and related code can be dropped in 4.3 with working autoloader - but
> that's a different RFC then. What do you think?
>
yes, can be dropped in a seperate RFC. Autoloader solves all this
problems at once.
Finally +1 by reading the new patch.
vg Steffen
More information about the TYPO3-team-core
mailing list