[TYPO3-core] RFC #9703: Integrate EXT: ingmar_admpanelwrap

[Oliver Hader]

Hi,

Oliver Hader schrieb:
> Hi Ingo,
> 
> Ingo Renner schrieb:
>> please find attached v4
>>
>> changes:
>>
>> * "namespaced" function names
>> * attached the dragging functions to the admin panel instead of the
>> whole document which should resolve issues with xmenu layer menus
>> * fixed an issue where the path for the cookie was not set (credits Stucki)
>> * updated to fit the fe_edit system extension
> 
> Some remarks:
> +		if (begin != 0)
> +			return null
> --> please wrap it in curly braces here
> 
> +	document.getElementById('admPanel').onmousemove = admPanel_drag;
> +	document.getElementById('admPanel').onmouseup = admPanel_dragstop;
> --> please remove "getElementById(...)." and use just
> document.onmousemove since it produces errors on drag&drop
> 
> Besides that: +1 on reading and testing

I've integrated the mentioned changes into the attached patch.
Furthermore there's now a JavsScript object "TYPO3AdminPanel" that
encapsulates the accordant functions.

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009703_v5.diff
Type: text/x-patch
Size: 5394 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090330/a45cdc6c/attachment-0001.bin