[TYPO3-core] RFC #9703: Integrate EXT: ingmar_admpanelwrap

Oliver Hader oliver at typo3.org
Fri Mar 27 03:12:55 CET 2009


Hi Ingo,

Ingo Renner schrieb:
> 
> please find attached v4
> 
> changes:
> 
> * "namespaced" function names
> * attached the dragging functions to the admin panel instead of the
> whole document which should resolve issues with xmenu layer menus
> * fixed an issue where the path for the cookie was not set (credits Stucki)
> * updated to fit the fe_edit system extension

Some remarks:
+		if (begin != 0)
+			return null
--> please wrap it in curly braces here

+	document.getElementById('admPanel').onmousemove = admPanel_drag;
+	document.getElementById('admPanel').onmouseup = admPanel_dragstop;
--> please remove "getElementById(...)." and use just
document.onmousemove since it produces errors on drag&drop

Besides that: +1 on reading and testing

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3


More information about the TYPO3-team-core mailing list