[TYPO3-core] RFC #10523: New install tool colors, matching t3skin

[Daniel Krupke]

Hi Susanne,

I tested your patch again, it works fine in FF3, IE7 with and without
BE Login. But I still have some small issues here.

First of all in Safari, Google Chrome and Opera: when you go to "8:
phpinfo()" the table width is widened so that you have to scroll
vertically. The width is three times higher than usual screen width.
It's caused by a very long line without whitespaces in section
ENVIRONMENT at Variable "LS_COLORS" with a very large value. I can
provide a screenshot if you want.

Second, the section "10: About" in Install Tool always has a lower
width than all the other menu items in Install Tool.

Finally, you sometimes use css like "display:inline;" instead of
"display: inline;" (no whitespace).

Install Tool Login Screen now looks great! Your cleanup of CSS is also
very good!

So long,
Daniel

2009/3/8 Susanne Moog <typo3 at susannemoog.de>:
> Benjamin Mack schrieb:
>> Hey Susanne,
>>
>> just after a quick look, I don't like the naming of the variable anymore...
>>
>> + $bgcolor = ($this->INSTALL['images_type']==$k ? ' class="activeMenu"'
>> : ' class="generalTableBackground"');
>>
>> It's not a $bgcolor anymore :). I know it's cosmetical but it might
>> confuse people who want to read our code :) Can we change that?
>
> Changed that in v5.
>
>> The whole change looks very promising in general, I'll have a deeper
>> look tomorrow. Maybe we could brush up the 1-2-3 installer after that :)
>
> Yes we should :)
>
> Other changes in v5:
> - Install tool is now nearly valid HTML4.01
> - As requested somewhere in the thread the about/login screen is smaller
> now than the others and does not look too strange anymore.
> - cleaned up css a bit
>
> Regards,
>
> Susanne
>
>
>
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-core
>



-- 
newmedia.solutions sk | Krupke & Siemon GbR
Daniel Krupke
Rosenbergstr. 28
70174 Stuttgart
M: +49 177 / 642 74 92
info at newmedia-solutions.de
www.newmedia-solutions.de
Skype: dkrupke