[TYPO3-core] RFC #10523: New install tool colors, matching t3skin

[Susanne Moog]

Benjamin Mack schrieb:
> Hey Susanne,
> 
> just after a quick look, I don't like the naming of the variable anymore...
> 
> + $bgcolor = ($this->INSTALL['images_type']==$k ? ' class="activeMenu"'
> : ' class="generalTableBackground"');
> 
> It's not a $bgcolor anymore :). I know it's cosmetical but it might
> confuse people who want to read our code :) Can we change that?

Changed that in v5.

> The whole change looks very promising in general, I'll have a deeper
> look tomorrow. Maybe we could brush up the 1-2-3 installer after that :)

Yes we should :)

Other changes in v5:
- Install tool is now nearly valid HTML4.01
- As requested somewhere in the thread the about/login screen is smaller
now than the others and does not look too strange anymore.
- cleaned up css a bit

Regards,

Susanne


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 10523_installToolColors_v5.patch
Type: text/x-diff
Size: 78547 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090308/23c4209e/attachment-0001.patch