[TYPO3-core] RFC #10523: New install tool colors, matching t3skin
Benjamin Mack
benni at typo3.org
Sun Mar 1 22:07:29 CET 2009
Hey Susanne,
just after a quick look, I don't like the naming of the variable anymore...
+ $bgcolor = ($this->INSTALL['images_type']==$k ? ' class="activeMenu"'
: ' class="generalTableBackground"');
It's not a $bgcolor anymore :). I know it's cosmetical but it might
confuse people who want to read our code :) Can we change that?
The whole change looks very promising in general, I'll have a deeper
look tomorrow. Maybe we could brush up the 1-2-3 installer after that :)
Great work.
All the best,
Benni.
More information about the TYPO3-team-core
mailing list