[TYPO3-core] RFC: Feature #10116: Remove/protect adodb testfiles

Martin Kutschker masi-no at spam-typo3.org
Tue Jan 13 11:16:13 CET 2009


Dmitry Dulepov schrieb:
> Hi!
> 
> Marcus Krause wrote:
>> Branches: 4-1, 4-2, trunk
>>
>> Bugtracker reference: http://bugs.typo3.org/view.php?id=10116
>>
>> Problem:
>> Adodb test files below typo3/sysext/adodb/adodb/tests/ are not
>> "production-grade" and not protected in any way. Besides, the code is a
>> total mess and IMHO not useful for TYPO3 at all.
>>
>> Solution:
>> The attached trunk-patch will remove the complete folder whereas the
>> other patch, to be applied on 4-1 and 4-2, will insert a die() statement
>> at the beginning of every test file.
> 
> Huge +1 to remove these files. But I would do it without a patch. I would prefer these svn commands:
> 
> svn rm typo3/sysext/adodb/cute_icons_for_site
> svn rm typo3/sysext/adodb/docs
> svn rm typo3/sysext/adodb/perf
> svn rm typo3/sysext/adodb/session
> svn rm typo3/sysext/adodb/tests

+1 to this one.

> I am not sure if dbal uses adodb language support. If not, we can get rid of that too:
> 
> svn rm typo3/sysext/adodb/lang

Where does ADOdb istelf uses these?

Masi

>> Notes:
>> I wouldn't mind, if the test folder could be completely removed in 4-1
>> and 4-2, too.
> 
> I think we should get rid of them in all supported versions. There is no even a sligtest chance than anyone can depend on test classes.

Fine with me.

Masi


More information about the TYPO3-team-core mailing list