[TYPO3-core] RFC: Feature #10116: Remove/protect adodb testfiles

[Dmitry Dulepov]

Hi!

Marcus Krause wrote:
> Branches: 4-1, 4-2, trunk
> 
> Bugtracker reference: http://bugs.typo3.org/view.php?id=10116
> 
> Problem:
> Adodb test files below typo3/sysext/adodb/adodb/tests/ are not
> "production-grade" and not protected in any way. Besides, the code is a
> total mess and IMHO not useful for TYPO3 at all.
> 
> Solution:
> The attached trunk-patch will remove the complete folder whereas the
> other patch, to be applied on 4-1 and 4-2, will insert a die() statement
> at the beginning of every test file.

Huge +1 to remove these files. But I would do it without a patch. I would prefer these svn commands:

svn rm typo3/sysext/adodb/cute_icons_for_site
svn rm typo3/sysext/adodb/docs
svn rm typo3/sysext/adodb/perf
svn rm typo3/sysext/adodb/session
svn rm typo3/sysext/adodb/tests

I am not sure if dbal uses adodb language support. If not, we can get rid of that too:

svn rm typo3/sysext/adodb/lang

> Notes:
> I wouldn't mind, if the test folder could be completely removed in 4-1
> and 4-2, too.

I think we should get rid of them in all supported versions. There is no even a sligtest chance than anyone can depend on test classes.

-- 
Dmitry Dulepov
TYPO3 core team

Mr. Harris: People say that you were the last person to speak with Jordon...
            Is that true? 
Cameron: I don't know. Are you asking me if people say I was the last person
            to talk to Jordon? Or are you asking me if I was the last person
            to talk to her? 
Mr. Harris: I guess I'm asking if you were. 
Cameron: I don't know.