[TYPO3-core] RFC #11431: Hook request for manipulating the pageID in getPage

[Christian Kuhn]

Hey,

Oliver Hader wrote:
> Oliver Hader schrieb:
>>> I hope this will lead to the missing +1 on testing from a core dev ;)
>> Thanks for providing a unit test that looks good so far.
>> Thus: +1 on testing
>>
>> However, I have some remarks concerning the patch:
>> 1) it's not said that the hook is only used for manipulating the page
>> uid, other things could be checked, too
>> -> I'd prefer something like getPage_preProcess instead of manipulatePageUid
>> 2) If you call a specific method in the hook object, it should implement
>> a given interface (e.g. look to tslib/interfaces/ to see how they are
>> used) - otherwise you could also use the callUserFunc alternative that
>> allows one to define the method to be called
> 
> I forgot one thing:
> Instead of testing with
> | $this->assertTrue(!$variable)
> you shout better use
> | $this->assertFalse($variable)


Thanks Oliver. Attached another version that honors all your points. I
also moved the hook to the very top of the method.

As this version again changed a bit I would like to get a new review
from anyone.

Thanks
Christian
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 11431_v6_testcase.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090828/d1562de4/attachment.txt 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 11431_v6.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090828/d1562de4/attachment-0001.txt