[TYPO3-core] RFC #11431: Hook request for manipulating the pageID in getPage

[Oliver Hader]

Hi Christian,

Christian Kuhn schrieb:
> Hey,
> 
> Oliver Hader wrote:
>> Oliver Hader schrieb:
>>>> I hope this will lead to the missing +1 on testing from a core dev ;)
>>> Thanks for providing a unit test that looks good so far.
>>> Thus: +1 on testing
>>>
>>> However, I have some remarks concerning the patch:
>>> 1) it's not said that the hook is only used for manipulating the page
>>> uid, other things could be checked, too
>>> -> I'd prefer something like getPage_preProcess instead of manipulatePageUid
>>> 2) If you call a specific method in the hook object, it should implement
>>> a given interface (e.g. look to tslib/interfaces/ to see how they are
>>> used) - otherwise you could also use the callUserFunc alternative that
>>> allows one to define the method to be called
>> I forgot one thing:
>> Instead of testing with
>> | $this->assertTrue(!$variable)
>> you shout better use
>> | $this->assertFalse($variable)
> 
> 
> Thanks Oliver. Attached another version that honors all your points. I
> also moved the hook to the very top of the method.
> 
> As this version again changed a bit I would like to get a new review
> from anyone.

Thanks for doing the work and creating a nicer version of that feature.

Here are some minor remarks concerning the patch:
* in the hook interface the method signature has 't3lib_pageSelect
&$parentObject' - the reference operator is not required for objects in PHP5
* the reference operator is also not required at t3lib_div::getUserObj()
* formatting issue at the if-block checking for the hook interface

I changed the mentioned stuff - see attached patch.

+1 on reading and testing

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3