[TYPO3-core] RFC #11431: Hook request for manipulating the pageID in getPage

[Oliver Hader]

Hi again,

Oliver Hader schrieb:
>> I hope this will lead to the missing +1 on testing from a core dev ;)
> 
> Thanks for providing a unit test that looks good so far.
> Thus: +1 on testing
> 
> However, I have some remarks concerning the patch:
> 1) it's not said that the hook is only used for manipulating the page
> uid, other things could be checked, too
> -> I'd prefer something like getPage_preProcess instead of manipulatePageUid
> 2) If you call a specific method in the hook object, it should implement
> a given interface (e.g. look to tslib/interfaces/ to see how they are
> used) - otherwise you could also use the callUserFunc alternative that
> allows one to define the method to be called

I forgot one thing:
Instead of testing with
| $this->assertTrue(!$variable)
you shout better use
| $this->assertFalse($variable)

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3