[TYPO3-core] RFC: #11731: [Bugfix] ENABLE_INSTALL_TOOL file check in yellow box doesn't check the file age
Michael Stucki
michael at typo3.org
Fri Aug 28 13:12:01 CEST 2009
Alright, thanks Olly and Moreno!
* Committed to TYPO3_4-1 (rev. @5841)
Additionally, I've closed the bug now.
- michael
Oliver Hader schrieb:
> Hi Michael,
>
> Michael Stucki schrieb:
>> As proposed by Moreno, this patch should also go into TYPO3_4-1.
>> Attached is an updated patch for this version.
>>
>> Although file_get_contents() is supported since PHP 4.3 I'm not sure if
>> this was already made a requirement for TYPO3 4.1. Therefore, I'm using
>> t3lib_div::getUrl() instead of file_get_contents() just to be safe.
>
> TYPO3 4.1 had a requirement for PHP 4.3.0:
> http://typo3.org/development/articles/release-notes-41/
>
> Thus, using file_get_contents() would be fine - also t3lib_div::getURL()
> TYPO3 4.1 uses that function. So, you could change the patch to use
> file_get_contents() or stay with t3lib_div::getURL() - both is fine with me.
>
> +1 on reading and testing
>
> olly
--
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/
More information about the TYPO3-team-core
mailing list