[TYPO3-core] RFC: #11731: [Bugfix] ENABLE_INSTALL_TOOL file check in yellow box doesn't check the file age

Oliver Hader oliver at typo3.org
Thu Aug 27 09:33:05 CEST 2009


Hi Michael,

Michael Stucki schrieb:
> As proposed by Moreno, this patch should also go into TYPO3_4-1.
> Attached is an updated patch for this version.
> 
> Although file_get_contents() is supported since PHP 4.3 I'm not sure if
> this was already made a requirement for TYPO3 4.1. Therefore, I'm using
> t3lib_div::getUrl() instead of file_get_contents() just to be safe.

TYPO3 4.1 had a requirement for PHP 4.3.0:
http://typo3.org/development/articles/release-notes-41/

Thus, using file_get_contents() would be fine - also t3lib_div::getURL()
TYPO3 4.1 uses that function. So, you could change the patch to use
file_get_contents() or stay with t3lib_div::getURL() - both is fine with me.

+1 on reading and testing

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3


More information about the TYPO3-team-core mailing list