[TYPO3-core] RFC #11684: Add support for flash messages in the backend

Ingo Renner ingo at typo3.org
Tue Aug 25 09:52:58 CEST 2009


Michael Stucki wrote:

Hi Michael,

> typo3/sysext/setup/mod/index.php:
> There is an if-condition that starts like this: if (true || ....)
> Seems like you didn't finish this one, did you?

This is not part of the RFC, it's only part of the test patch to force 
that one message to appear. Othewrwise you'd probably never see it 
except when updating from EXT:csh_XX times to current l10n handling of 
backend language labels.


> @author tags in phpDoc headers:
> I thought we agreed that this is a waste of space. As soon as someone
> else changes a single character in the function, the information that
> you were the only responsible author for this function becomes invalid.
> For things like this we can rely on SVN blame which is always more
> precise than a static information. Therefore, please remove those tags
> from allover the code.

I can not remove it from the methods taken from FLOW3 where Karsten is 
the original author, otherwise I'm fine with that of course.

> Besides this, the code looks great and is even working! :-)
> +1 on testing and +1 for the code review. Just make sure to fix the
> mentioned stuff and go ahead!

Thanks
Ingo

-- 
Ingo Renner
TYPO3 Core Developer, Release Manager TYPO3 4.2



More information about the TYPO3-team-core mailing list