[TYPO3-core] RFC: #11397: [Feature] Add class for render HTML header/footer for BE and FE

[Steffen Kamper]

Hi Steffen,

Steffen Ritter schrieb:
> Hey Steffen,
> i just read the patch.
> You make the pagen script much more readable :) I like it.
>
:)


> There are some "but":
> - sometimes it seems to mee you introduced empty lines (fe. first + 
> lines in tslib_pagegen.php)
this is result of the hard work there, i don't think these too lines hurt

> -  i think you removed config.headerComment functionality. In original 
> pagegen script $customContent + standardtext was added, in new version 
> only the the TYPO3 one is included. have a look at lines 1250 - 1268 in 
> your diff.

look at line 1213 where it's done

> - config.noPageTitle=1, I'm not shure if this is respected. About 2 you 
> take care...
>
works same as before

> Besides of this. Great job :)
> 

thanks! Unfortunally one small typo has found the way into the patch, so 
here is the corrected one.

vg Steffen
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: page_includes_complete_v4.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090803/7a1257cc/attachment-0001.txt