[TYPO3-core] RFC: #11397: [Feature] Add class for render HTML header/footer for BE and FE
Steffen Ritter
info at rs-websystems.de
Mon Aug 3 15:22:17 CEST 2009
Steffen Kamper schrieb:
> Hi,
>
> i reformatted the class.
> * proper getter/setter methods
> * proper phpDocs
> * added unit test with all functions
>
> I also added the request from #11611 as described in the thread
>
> A complete documentation of the TS will follow these days.
>
> vg Steffen
>
Hey Steffen,
i just read the patch.
You make the pagen script much more readable :) I like it.
There are some "but":
- sometimes it seems to mee you introduced empty lines (fe. first +
lines in tslib_pagegen.php)
- i think you removed config.headerComment functionality. In original
pagegen script $customContent + standardtext was added, in new version
only the the TYPO3 one is included. have a look at lines 1250 - 1268 in
your diff.
- config.noPageTitle=1, I'm not shure if this is respected. About 2 you
take care...
Besides of this. Great job :)
regards Steffen
More information about the TYPO3-team-core
mailing list