[TYPO3-core] RFC: #11397: [Feature] Add class for render HTML header/footer for BE and FE

Wed Aug 5 23:08:46 CEST 2009

I have tested the different configuration of the first post

Here a short feedback:

:) page.stylesheet: works fine!
:) page.includeCSS: works fine!
:) page.CSS_inlineStyle: works fine!
:) page.javascriptLibs: works fine!

:/ page.jsInline. the JS is displayed in the <header> which is good. But I have notice the old key 
"inlineJS" which does not seem to work. Is it normal?

:( page.includeJS. displayed in the <body>. Is it normal?
:( page.includeJSlibs. Does the same work as includeJs. Displayed in the <body> as well.

:) page.jsFooterInline: works fine!

:( config.moveJsFromHeaderToFooter = 1 Has not worked for me. It could be possible, I have not 
tested in the correct way.
:( config.minifyJS = 1 Nothing special has happened
:( config.minifyCSS = 1 Nothing special has happened
:( config.concatenateJSandCSS = 1 Nothing special has happened

I will be available on Skype on Thursday afternoon to discuss it if necessary.

Cheers,

Fabien

On 3.8.2009 15:52, Steffen Kamper wrote:
> Hi Steffen,
>
> Steffen Ritter schrieb:
>> Hey Steffen,
>> i just read the patch.
>> You make the pagen script much more readable :) I like it.
>>
> :)
>
>
>> There are some "but":
>> - sometimes it seems to mee you introduced empty lines (fe. first +
>> lines in tslib_pagegen.php)
> this is result of the hard work there, i don't think these too lines hurt
>
>> - i think you removed config.headerComment functionality. In original
>> pagegen script $customContent + standardtext was added, in new version
>> only the the TYPO3 one is included. have a look at lines 1250 - 1268
>> in your diff.
>
> look at line 1213 where it's done
>
>> - config.noPageTitle=1, I'm not shure if this is respected. About 2
>> you take care...
>>
> works same as before
>
>> Besides of this. Great job :)
>>
>
> thanks! Unfortunally one small typo has found the way into the patch, so
> here is the corrected one.
>
> vg Steffen