[TYPO3-core] RFC #9284: Feature: tt_content.starttime/endtime have now effect on caching (with patchfile now, sry)

[Ingo Renner]

Martin Holtz wrote:

Hi Martin,

>> * the diff is not against the root of TYPO3 (not a big problem though,
>> just keep that in mind)
> i hope it is correct now?

yes, now it's correct.

>> * line 10: until there's a final decision about the indentation of
>> inline comments and until this decision is released, inline comments are
>> indented with one tab (also applies to all other inlne comments in your
>> patch)
> should be correct now?

yes

>> * line 14: you either check whether this method exists or go with (the
>> better way of) requiring the object to implement an interface (check
>> t3lib/interfaces/ f.e.)
> i did, but i didnt now how the timestamp for the exception is generated -
> timestamp at coding time? Is there an doc where i have to put it into?

right, this is the timestamp when you wrote that line (should be 
documented in the new CGL).
I added a proper timestamp and also added a check like you did with the 
$TSFE->cacheExpires.

>> * line 23: split the parameter of exec_SELECTquery onto one line each
> hope it is correct now?

yes, better. additional ANDs in WHERE clauses can be indeted with an 
additional tab, each one on a separate line...

>> In general you can't use the default cache period for calculations,
>> there's a separate field for the cache period in table pages, use this
>> field's value.
> that is done in realPageCacheContent()  the parameter $tstamp in
> setPageCacheContent() is the calculated timestamp which depends on
> page-setting, clearCacheAtMidnight etc. But that is done before
> setPageCacheContent

ok

> 2) The page with the message "Page is generated" is cached too - but only
> for 30 seconds. I think it would not be usefull to use the hook in such an
> case.

good point

now +1 after reading for the attached version, still needs testing though.


Ingo

-- 
Ingo Renner
TYPO3 Core Developer, Release Manager TYPO3 4.2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 9284.diff
Type: text/x-diff
Size: 5750 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080907/193e1fad/attachment.diff